-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from master for rook #750
base: release-4.18
Are you sure you want to change the base?
Conversation
Existing OSD migration process is limited to updating the OSD backend store. This docs proposes a more generic API for the OSD migration that will help with other scenarios as well. Signed-off-by: Santosh Pillai <[email protected]>
If the mon failover is in progress, ensure the removal of an extra mon deployment is skipped since that code path only has one mon in the list for the mon that was just newly started. The extra mon was erroneously removing a random mon in that case, followed immediately by the mon failover completing and removing the expected failed mon, and potentially causing mon quroum loss. Signed-off-by: Travis Nielsen <[email protected]>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@aaa42aa...971e284) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.9 to 3.26.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@461ef6c...6db8d63) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [golang/govulncheck-action](https://github.com/golang/govulncheck-action) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/golang/govulncheck-action/releases) - [Commits](golang/govulncheck-action@dd0578b...b625fbe) --- updated-dependencies: - dependency-name: golang/govulncheck-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
mon: Do not remove extra mon in middle of failover
…angci/golangci-lint-action-6.1.1 build(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1
This step consumes several minutes per job. Signed-off-by: Joshua Hoblitt <[email protected]>
…hub/codeql-action-3.26.11 build(deps): bump github/codeql-action from 3.26.9 to 3.26.11
…ang/govulncheck-action-1.0.4 build(deps): bump golang/govulncheck-action from 1.0.3 to 1.0.4
test: rm canary/integration "Free Disk Space" step
doc: osd migration design
Do not force delete resources in validation cleanup. Force deletion can result in CNI IP address management (IPAM) addresses not being released cleanly, exhausting them. This can then lead to Rook cluster deploy failure if the CNI IPAM isn't able to garbage collect the IPs quickly. Signed-off-by: Blaine Gardner <[email protected]>
for 4.18 we will use the default v2 settings from the cluster CR So ask python script to fetch only v2 port Signed-off-by: parth-gr <[email protected]>
…-force-delete multus: do not force delete in validation cleanup
Modify the CR to allow mirroring of an rados namespace to a differently named namespace on the remote cluster 1) enable rados namesapce mirroring only if the blockpool mirrroing is enabled 2) disable blockpool mirroing only if all the namesapce mirroing is disabled if the rbd mirroring fails and ceph version is not supported provide a error message with supported version details and reason of failing Signed-off-by: parth-gr <[email protected]>
external: enable the v2 port by default in downstream
rbdmirror: enable rbd rados namespace mirroring
Syncing latest changes from upstream master for rook
Disabling the RBD and CephFS fencing in Rook for now as its having bugs where Rook is blocklisting wrong IP address due to timing issues. Signed-off-by: Madhu Rajanna <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
csi: disable fencing in Rook
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
Syncing latest changes from upstream master for rook
@Nikhil-Ladha Please check why auto-generated PR is adding csv changes https://github.com/red-hat-storage/rook/actions/runs/11285096924/job/31387343578?pr=750 |
I see this PR #748 was merged without commiting the gen-csv changes. The action was failing for that PR and we still merged it, why @parth-gr @travisn ? |
@Nikhil-Ladha missed checking if Linux build was failing because of it, wasn't sure if changing the python script would have impacted the csv, it was not before like this, Thanks for notifying it:) |
@Nikhil-Ladha we have the changes by Jenkins yesterday 7370faa |
@Mergifyio rebase |
No, we shouldn't be doing this. |
@Nikhil-Ladha should I raise manual PR to add csv changes in 4.18 and then this will be fixed or what is the solution? |
Let's wait for the next stable build to happen so that we have the latest commits from the master branch, considering we have the csv changes because of the u/s to d/s sync pipeline in the master branch already. |
PR containing the latest commits from master branch